Save Failed

This topic contains 6 replies, has 3 voices, and was last updated by Profile photo of support-piotr support-piotr 5 days, 14 hours ago.

Viewing 7 posts - 1 through 7 (of 7 total)
  • Author
    Posts
  • #536080
    Profile photo of Fedor Losev
    Fedor Losev
    Participant

    I have a component which implements one interface with methods and one with optional properties (but no implementation in the body).

    After clicking on error mark, there is no suggest to implement interfaces and after this IDE goes completely unusable, getting errors below on any , even unrelated file save.

    #536222 Reply
    Profile photo of support-swapna
    support-swapna
    Moderator

    Fedor,

    Sorry that you are seeing this issue. I could not replicate the problem at my end. I do see the suggestion to implement the interface. I will file the stacktrace for further investigation with the dev team.

    Can you please clarify if you see this problem consistently or in a new workspace as well? If possible please share with us the code snippets to help us replicate the problem at our end.

    Please also send us the full log file from workspace dir/.metadata/.log.

    Apologies for inconvenience caused.

    –Swapna
    MyEclipse Support

    #538975 Reply
    Profile photo of Fedor Losev
    Fedor Losev
    Participant

    a.ts:

    b.ts:

    ab.ts:

    Close all files. Open ab.ts and change to:

    Close all files. Open AB and click on error mark “Incorrectly implements”. Either nothing happens or there is the same tooltip message without option to fix.

    After that, saving a ts file (even unrelated) will result in the error above until IDE restart.

    Note, while this happens now consistently, the very first time it gave me the option to implement the interface and it worked. But after closing, reopening and removing the implemented code, clickin on the error mark resulted in the above. Deleting these files, restarting and creating them again resulted in this behavior right away, without working properly first time.

    • This reply was modified 1 week, 1 day ago by Profile photo of Fedor Losev Fedor Losev.
    #539021 Reply
    Profile photo of support-swapna
    support-swapna
    Moderator

    Fedor,

    Thank you for the code snippets and the detailed instructions. I see the exception logged when hovering over the error in the editor but not during any .ts file save.

    The dev team is investigating further. We will keep you posted about the fix.

    Apologies for inconvenience caused.

    –Swapna
    MyEclipse Support

    #539028 Reply
    Profile photo of Fedor Losev
    Fedor Losev
    Participant

    Note the save error happens not on hovering but after clicking on the error mark and then editing the file.

    #539183 Reply
    Profile photo of support-piotr
    support-piotr
    Moderator

    Fedor,

    Unfortunately, this is an issue in TypeScript language services themselves. Formatting Scanner is not being closed within TS code (missing try/finally block) as a result of an error thrown from formatter. For this quick fix we are relaying on TS Services to create its contents, as the services are supposed to provide advanced formatting of the content. It clearly looks buggy. Anyway, as the scanner is not closed, all further calls to formatter are being rejected.

    The issue has been fixed recently: https://github.com/Microsoft/TypeScript/pull/18293 , but the targeted release is 2.6.0. As of now we have avoided patching TypeScript Language Services code and we have to carefully investigate our options. We will keep you posted.

    • This reply was modified 6 days, 16 hours ago by Profile photo of support-piotr support-piotr.
    #539377 Reply
    Profile photo of support-piotr
    support-piotr
    Moderator

    Fedor,

    I am happy to inform you that monkey patching worked out and the fix for the issue will be available in the next release. Of course an error will still be logged in your case due to a bug in TS, but at least it won’t cause any issue afterwards.

Viewing 7 posts - 1 through 7 (of 7 total)

You must be logged in to reply to this topic.